This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Kill regexp.h
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 24 Jul 2015 23:45:21 -0400
- Subject: Re: [PATCH] Kill regexp.h
- Authentication-results: sourceware.org; auth=none
- References: <20150712195501 dot D8E5C14B9A at panix1 dot panix dot com> <55A57D59 dot 4090104 at redhat dot com> <CAKCAbMiGYx9dXsT3WF0ZQhum8757O-TWEhzzf_=mdRAO3rksXQ at mail dot gmail dot com> <55A65C27 dot 2020808 at redhat dot com> <55A66676 dot 7070500 at panix dot com>
On 07/15/2015 09:56 AM, Zack Weinberg wrote:
> On 07/15/2015 09:12 AM, Carlos O'Donell wrote:
>> On 07/14/2015 08:20 PM, Zack Weinberg wrote:
>>>> At a high level your patch looks OK, it makes sense to deprecate
>>>> these interfaces, but I think we should to do this in two stages.
>>>> Add warnings and then remove.
>>>
>>> Hm. If we do that then I would feel obliged to fix the bugs in the
>>> header in phase one. I'm not sure that's worth doing...
>>
>> Worth is certainly in the eye of the beholder. How would you feel if
>> you were a user of this interface?
>
> So thinking about this a bit more, would you take this patch for 2.22?
> All it does is add #warning directives and correct the RETURN .vs. ERROR
> thing (leaving the memory-allocation issue reported in Debian).
Maybe, but only because I'd like someone to review it.
I *may* get to reviewing it and push the patch myself,
but I can't promise that, otherwise we'll get to it in
2.23.
I apologize if that seems lame. We need more reviewers.
c.