This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Avoid mapping past end of shared object (BZ #18685)

From: Mike Frysinger <vapier at gentoo dot org>
To: Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: libc-alpha at sourceware dot org, roland at hack dot frob dot com
Date: Thu, 16 Jul 2015 06:14:29 -0400
Subject: Re: [PATCH] Avoid mapping past end of shared object (BZ #18685)
Authentication-results: sourceware.org; auth=none
References: <1437033625-13561-1-git-send-email-siddhesh at redhat dot com>

On 16 Jul 2015 13:30, Siddhesh Poyarekar wrote:
> +	  if (__glibc_unlikely (ph->p_offset + ph->p_filesz > st.st_size))

p_offset and p_filesz are 64bit w/64bit ELFs, so seems like this too could 
overflow wrt the 64bit st_size.  is there some other check earlier on that
would catch that ?
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] Avoid mapping past end of shared object (BZ #18685)
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]