This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v5] Fix dynamic linker issue with bind-now


-----Original Message-----
From: H.J. Lu [mailto:hjl.tools@gmail.com] 
Sent: Tuesday, July 14, 2015 8:36 PM
To: Petar Jovanovic <petar.jovanovic@rt-rk.com>
Cc: GNU C Library <libc-alpha@sourceware.org>; Roland McGrath <roland@hack.frob.com>; Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v5] Fix dynamic linker issue with bind-now

> Please put ChangeLog entry in your commit log, not in ChangeLog directly.  Otherwise, your patch may not apply.  If you can't check it in yourself,. please generate the patch with " gcc format-patch".

You mean with "git format-patch"? So far, I have been using git send-email, but I can create it with "git format-patch" and attach it to the email. I will put ChangeLog as part of the message text.

>> +           && ((do_lazy) || ranges[0].size == 0                              \
> Please put " ranges[0].size == 0" on separate line.

Done in the next patch set (v6).

>> +               || ranges[0].start + ranges[0].size != start))                \
> Please add () around "ranges[0].start + ranges[0].size".

Done in the next patch set (v6).

>> +static int __attribute__ ((section(".bar"))) bar = 0x12345678;
> Please make "bar" readonly to avoid writable and executable segment.

As "static int const __attribute__ ..."?
In that case, bar is removed from the sections list, likely due to some optimizations.

> Please verify your testcase with the linker from the current binutils master branch.  The new linker doesn't have DT_JMPREL at all when -z now is used and the testcase works even without your patch.  Please update the testcase such that it always fails without the fix.

It seems that some (recent) changes from binutils had impact on this test case. I have modified it in patch v6, so it fails again. I find the change obvious, that we could even leave out the test case. But it is there in v6.

Regards,
Petar


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]