RE: [PATCH, MPX] MPX-specific changes in dl_runtime routines

["Zamyatin, Igor" <igor dot zamyatin at intel dot com>]

Fixed in the attached patch


Thanks,
Igor

> -----Original Message-----
> From: H.J. Lu [mailto:hjl.tools@gmail.com]
> Sent: Wednesday, July 8, 2015 6:35 PM
> To: Zamyatin, Igor
> Cc: libc-alpha@sourceware.org
> Subject: Re: [PATCH, MPX] MPX-specific changes in dl_runtime routines
> 
> On Wed, Jul 8, 2015 at 8:25 AM, Zamyatin, Igor <igor.zamyatin@intel.com>
> wrote:
> > Hi!
> >
> > Please see updated patch (attached)
> >
> > ChangeLog:
> >
> > 2015-07-08  Igor Zamyatin  <igor.zamyatin@intel.com>
> >
> >         [BZ #18134]
> >         * sysdeps/i386/dl-trampoline.S (_dl_runtime_profile): Save
> >         and restore Intel MPX return bound registers.
> >         * sysdeps/x86_64/dl-trampoline.h: Add PRESERVE_BND_REGS_PREFIX
> to
> >         call, jump and ret instructions to not loose bounds.
> >         * sysdeps/x86/bits/link.h (La_i86_retval): Add lrv_bnd0 and
> >         lrv_bnd1.
> >         * sysdeps/i386/link-defines.sym: Add definitions for
> LRV_BND0_OFFSET
> >         and LRV_BND1_OFFSET.
> >
> 
> +#else
> + .byte 0x66,0x0f,0x1b,0x04,0x24
> + .byte 0x66,0x0f,0x1b,0x4c,0x24,0x08
> +#endif
> ...
> +#else
> + .byte 0x66,0x0f,0x1a,0x04,0x24
> + .byte 0x66,0x0f,0x1a,0x4c,0x24,0x08
> +#endif
> 
> Please use LRV_BND0_OFFSET and LRV_BND1_OFFSET.
> 
> 
> --
> H.J.

Attachment: mpx_glibc_dl_runtime_profile_all.patch
Description: mpx_glibc_dl_runtime_profile_all.patch