This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] libio: Update tst-fmemopen2.c



On 07-07-2015 16:48, Carlos O'Donell wrote:
> On 06/16/2015 09:56 AM, Adhemerval Zanella wrote:
>> Reposting to see if I can land it for 2.22.
>>
>> --
>>
>> This patch updates tst-fmemopen2 to check for fmemopen with NULL buffer
>> inputs and also refactor the code a bit.
>>
>> The test relies on a POSIX compliant fmemopen implementation.
>>
>> Tested on x86_64, i386, aarch64, and arm-linux-gnueabihf.
>>
>> 	* stdio-common/tst-fmemopen2.c (do_test): Add test for NULL and zero
>> 	length buffers.
>> 	* stdio-common/tst-fmemopen.c (do_test): Refactor to use
>> 	test-skeleton.c.
> 
> OK with nits fixed and after you checkin the fmemopen fixes.

Thanks for the review, I have updated the patch with all your requests and 
I have also  added some more comments about the tests intentions.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]