This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][AArch64] make setcontext etc functions consistent with the kernel
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 6 Jul 2015 11:00:52 +0100
- Subject: Re: [PATCH][AArch64] make setcontext etc functions consistent with the kernel
- Authentication-results: sourceware.org; auth=none
- References: <5555CA8C dot 6030000 at arm dot com> <559A4F43 dot 6010701 at arm dot com>
On 6 July 2015 at 10:49, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> On 15/05/15 11:29, Szabolcs Nagy wrote:
>> since
>> https://sourceware.org/ml/libc-alpha/2014-04/msg00006.html
>> setcontext etc is no longer tied to the kernel use of ucontext.
>>
>> in that patch the ucontext reserved space is not used consistently
>> with the kernel abi: the d8,d9 pair is saved in the slot of q8.
>>
>> this is ok (*context functions work together), but probably not
>> desirable (ucontexts created by the kernel and getcontext are
>> subtly different).
>>
>> the fix just replaces dN with qN in the save/restore code, which
>> does a bit more than needed (saves/restores the top half of qN that
>> is not callee saved), but this should not be an issue (and avoids
>> having to deal with endianness).
>>
>
> ping.
This is OK. /Marcus