This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 04 Jul 2015 08:39, H.J. Lu wrote: > --- /dev/null > +++ b/sysdeps/i386/tst-audit3.c > > +extern long long audit1_test (int, int, int) __attribute__ ((regparm(3))); > +extern float audit2_test (int, int, int) __attribute__ ((regparm(3))); better to create a local header than copy & paste this in multiple places ? > +long long > +__attribute__ ((regparm(3))) > +audit1_test (int i, int j, int k) > +{ > + if (i != 1 || j != 2 || k != 3) only one space before k > + abort (); isn't this what assert() is for ? or are you worried about compile settings ? > +float > +__attribute__ ((regparm(3))) > +audit2_test (int i, int j, int k) > +{ > + if (i != 1 || j != 2 || k != 3) only one space before k > +void > +la_activity (uintptr_t *cookie, unsigned int flag) > +{ > + if (flag == LA_ACT_CONSISTENT) > + printf ("activity: consistent\n"); > + else if (flag == LA_ACT_ADD) > + printf ("activity: add\n"); > + else if (flag == LA_ACT_DELETE) > + printf ("activity: delete\n"); > + else > + printf ("activity: unknown activity %u\n", flag); > +} could do at the start: printf ("activity: "); then make it a case statement > +char * > +la_objsearch (const char *name, uintptr_t *cookie, unsigned int flag) > +{ > + char buf[100]; > + const char *flagstr; > + if (flag == LA_SER_ORIG) > + flagstr = "LA_SET_ORIG"; > + else if (flag == LA_SER_LIBPATH) > + flagstr = "LA_SER_LIBPATH"; > + else if (flag == LA_SER_RUNPATH) > + flagstr = "LA_SER_RUNPATH"; > + else if (flag == LA_SER_CONFIG) > + flagstr = "LA_SER_CONFIG"; > + else if (flag == LA_SER_DEFAULT) > + flagstr = "LA_SER_DEFAULT"; > + else if (flag == LA_SER_SECURE) > + flagstr = "LA_SER_SECURE"; > + else > + { > + sprintf (buf, "unknown flag %d", flag); > + flagstr = buf; > + } seems like a case statement would be better ? -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |