This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #18508] S390: Fix "backtrace() returns infinitely deep stack frames with makecontext()".
- From: Florian Weimer <fweimer at redhat dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Date: Fri, 03 Jul 2015 11:11:44 +0200
- Subject: Re: [PATCH][BZ #18508] S390: Fix "backtrace() returns infinitely deep stack frames with makecontext()".
- Authentication-results: sourceware.org; auth=none
- References: <ml71gu$et2$1 at ger dot gmane dot org> <557AA306 dot 4090208 at redhat dot com> <mleq97$5v2$1 at ger dot gmane dot org> <87eglhvsst dot fsf at igel dot home> <mlm3f3$bbu$1 at ger dot gmane dot org>
On 06/15/2015 10:47 AM, Stefan Liebler wrote:
> +/* We do not want .eh_frame info for __makecontext_ret to stop unwinding
> + if backtrace() was called within a context created by makecontext.
> + (there is also no .eh_frame info for _start or thread_start) */
> +/* We do not want .eh_frame info for __makecontext_ret to stop unwinding
> + if backtrace() was called within a context created by makecontext.
> + (there is also no .eh_frame info for _start or thread_start) */
I think this should read:
âWe do not want .eh_frame ifno so that __makecontext_ret stops unwinding
if backtrace was called within a context created by makecontext. (There
is also no .eh_frame info for _start or thread_start.)â
Could a native speaker review this, please?
Rest of the patch seems okay to me.
--
Florian Weimer / Red Hat Product Security