This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/* v3] Generic string function optimization: Add skeleton
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: Richard Henderson <rth at twiddle dot net>, <libc-alpha at sourceware dot org>
- Date: Thu, 28 May 2015 20:54:31 +0000
- Subject: Re: [PATCH 1/* v3] Generic string function optimization: Add skeleton
- Authentication-results: sourceware.org; auth=none
- References: <20150527060121 dot GA19105 at domone> <20150528142956 dot GA25176 at domone> <556754ED dot 70804 at twiddle dot net> <20150528180439 dot GB4872 at domone>
On Thu, 28 May 2015, OndÅej BÃlka wrote:
> Both comments are correct. We should do it generically and surround
> these functions with ifdef to supply arch-specific versions.
#if, not #ifdef, please, for all architecture choices in these functions.
The sysdeps/generic version of the header architectures can use to change
the default choices should have detailed comments on the default
definitions of all the relevant macros to explain their semantics.
--
Joseph S. Myers
joseph@codesourcery.com