This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/*] Move string inlines to string/string-inlines.c
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 28 May 2015 16:02:52 +0000
- Subject: Re: [PATCH 1/*] Move string inlines to string/string-inlines.c
- Authentication-results: sourceware.org; auth=none
- References: <20150524150715 dot GA31589 at domone>
On Sun, 24 May 2015, Ondřej Bílka wrote:
> Hi,
>
> As described in header cleanup thread this is first step.
> It just copies inline function declarations to string-inlines.c
> An objdump -d produce same assembly.
As I noted in
<https://sourceware.org/ml/libc-alpha/2015-05/msg00248.html>, there is a
separate x86 version of string-inlines.c. Thus, any patches moving
inlines to string-inlines.c need to handle both the generic version and
the x86 one, in a way that avoids duplicating function definitions in any
cases where x86 uses the generic definitions from bits/string2.h in
string-inlines.c at present (in many cases it may not, if
sysdeps/x86/bits/string.h overrides them, so I don't know if there's
actually much duplication to avoid). And such patches need testing both
on 32-bit x86 and on another architecture such as x86_64.
(sysdeps/i386/string-inlines.c can be ignored or removed since plain i386
is no longer supported; only string/string-inlines.c and
sysdeps/i386/i486/string-inlines.c are relevant.)
--
Joseph S. Myers
joseph@codesourcery.com