This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED PATCH] Split timed-wait functions out of nptl/lowlevellock.c.
- From: Torvald Riegel <triegel at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Wed, 27 May 2015 10:51:49 +0200
- Subject: Re: [COMMITTED PATCH] Split timed-wait functions out of nptl/lowlevellock.c.
- Authentication-results: sourceware.org; auth=none
- References: <20150526221729 dot 7B7762C39FC at topped-with-meat dot com>
On Tue, 2015-05-26 at 15:17 -0700, Roland McGrath wrote:
> This lets a configuration replace __lll_timedlock_wait and/or
> __lll_timedwait_tid with different implementations while still
> using the generic code for __lll_lock_wait{,_private}.
It seems you made the split just to support the absolute timeout path
that NaCl futexes provide out of the box. IMO, this should have been
addressed by fixing the glibc-internal futex API, not by adding a
NaCl-specific variant and lots of new dummy files just to get back to
the common implementation for all other archs. Didn't we agree to have
as much commonality in our synchronization code as possible?
I'd appreciate if we could have discussion on such patches in the future
before they are committed. (And I wouldn't mind at all if you'd revert
this patch.)