This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix lseek64 for aarch64 ILP32
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 20 May 2015 15:58:51 +0000
- Subject: Re: Fix lseek64 for aarch64 ILP32
- Authentication-results: sourceware.org; auth=none
- References: <mvm1tibboep dot fsf at hawking dot suse dot de>
On Wed, 20 May 2015, Andreas Schwab wrote:
> This is needed on top of
> https://sourceware.org/ml/libc-alpha/2014-10/msg00596.html and
> http://sourceware.org/ml/libc-alpha/2015-03/msg00586.html to fix the
> return value of lseek64 in the error case. Without this change it
> returns 0xffffffff instead of -1.
Is there an existing testcase in the glibc testsuite that would have
failed for this issue, given the AArch64 ILP32 patches without this extra
patch? If not, could one be added?
There's a large pile of AArch64 ILP32 patches in patchwork. Some had
review comments from various people and need revision, but I think a lot
may not have been reviewed (and some may be waiting for kernel changes to
go in before anything can happen).
--
Joseph S. Myers
joseph@codesourcery.com