Re: [PATCH] Add envz_remove to the libc manual

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Tue, May 19, 2015 at 08:31:15PM +0000, Joseph Myers wrote:
> The manual build / install now fails:
> 
> /bin/sh ./check-safety.sh intro.texi creature.texi errno.texi memory.texi 
> ctype.texi string.texi charset.texi locale.texi message.texi search.texi 
> pattern.texi io.texi stdio.texi llio.texi filesys.texi pipe.texi 
> socket.texi terminal.texi syslog.texi math.texi arith.texi time.texi 
> resource.texi setjmp.texi signal.texi startup.texi getopt.texi argp.texi 
> process.texi ipc.texi job.texi nss.texi nsswitch.texi users.texi 
> sysinfo.texi conf.texi crypt.texi debug.texi threads.texi probes.texi 
> lang.texi header.texi install.texi macros.texi maint.texi platform.texi 
> contrib.texi freemanuals.texi lgpl-2.1.texi fdl-1.3.texi
> string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
> grep: write error
> string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
> string.texi:2794:@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
> make[2]: *** [/home/jsm28/nobackup/glibc/build-64/manual/stamp-summary] 
> Error 1
> make[2]: Leaving directory `/home/jsm28/nobackup/glibc/libc/manual'
> make[1]: *** [manual/subdir_install] Error 2
> make[1]: Leaving directory `/home/jsm28/nobackup/glibc/libc'
> make: *** [install] Error 2

Ugh, sorry, a typo snuck in and I didn't adequately test it.  I've
pushed the fix below.

Siddhesh

commit 654055e09332a0be9a2f0439dbc052e6a82f448a
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Wed May 20 02:36:13 2015 +0530

    Fix typo in safety annotations in envz_remove

diff --git a/ChangeLog b/ChangeLog
index 5080370..231f165 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-19  Siddhesh Poyarekar  <siddhesh@redhat.com>
+
+	* manual/strings.texi (envz_remove): Fix typo in safety
+	annotations.
+
 2015-05-19  Paul Eggert  <eggert@cs.ucla.edu>
 	    Steve Ellcey  <sellcey@imgtec.com>
 
diff --git a/manual/string.texi b/manual/string.texi
index c53e73a..5f8a17e 100644
--- a/manual/string.texi
+++ b/manual/string.texi
@@ -2791,7 +2791,7 @@ updating @code{*@var{envz}} and @code{*@var{envz_len}}.
 @comment envz.h
 @comment GNU
 @deftypefun {void} envz_remove (char **@var{envz}, size_t *@var{envz_len}, const char *@var{name})
-@safety{@prelim{}@mtsafe{}@asunsafe{@acsuheap{}}@acunsafe{@acsmem{}}}
+@safety{@prelim{}@mtsafe{}@asunsafe{@ascuheap{}}@acunsafe{@acsmem{}}}
 The @code{envz_remove} function removes an entry named @var{name} from
 @var{envz}, updating @code{*@var{envz}} and @code{*@var{envz_len}}.
 @end deftypefun

Attachment: pgpO6ytIhffDD.pgp
Description: PGP signature