This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][AArch64] Inline __ieee754_sqrt(f)
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Fri, 15 May 2015 12:18:15 +0100
- Subject: Re: [PATCH][AArch64] Inline __ieee754_sqrt(f)
- Authentication-results: sourceware.org; auth=none
- References: <000101d07776$0c9c4ac0$25d4e040$ at com>
On 15/04/15 13:16, Wilco Dijkstra wrote:
> Inline __ieee754_sqrt and __ieee754_sqrtf. Also add external definitions.
>
> OK for commit?
>
ping
(looks good to me and same should be done for fabs)
> 2015-04-15 Wilco Dijkstra <wdijkstr@arm.com>
>
> * sysdeps/aarch64/fpu/math_private.h (__ieee754_sqrt):
> New function. (__ieee754_sqrtf): New function.
> * sysdeps/aarch64/fpu/e_sqrt.c (__ieee754_sqrt):
> New function.
> * sysdeps/aarch64/fpu/e_sqrtf.c (__ieee754_sqrtf):
> New function.
>
> ---
> sysdeps/aarch64/fpu/e_sqrt.c | 28 ++++++++++++++++++++++++++++
> sysdeps/aarch64/fpu/e_sqrtf.c | 28 ++++++++++++++++++++++++++++
> sysdeps/aarch64/fpu/math_private.h | 16 ++++++++++++++++
> 3 files changed, 72 insertions(+)
> create mode 100644 sysdeps/aarch64/fpu/e_sqrt.c
> create mode 100644 sysdeps/aarch64/fpu/e_sqrtf.c
>
> diff --git a/sysdeps/aarch64/fpu/e_sqrt.c b/sysdeps/aarch64/fpu/e_sqrt.c
> new file mode 100644
> index 0000000..4f11ca2
> --- /dev/null
> +++ b/sysdeps/aarch64/fpu/e_sqrt.c
> @@ -0,0 +1,28 @@
> +/* Square root of floating point number.
> + Copyright (C) 2015 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <math_private.h>
> +
> +double
> +__ieee754_sqrt (double d)
> +{
> + double res;
> + asm ("fsqrt %d0, %d1" : "=w" (res) : "w" (d));
> + return res;
> +}
> +strong_alias (__ieee754_sqrt, __sqrt_finite)
> diff --git a/sysdeps/aarch64/fpu/e_sqrtf.c b/sysdeps/aarch64/fpu/e_sqrtf.c
> new file mode 100644
> index 0000000..a2e99e1
> --- /dev/null
> +++ b/sysdeps/aarch64/fpu/e_sqrtf.c
> @@ -0,0 +1,28 @@
> +/* Single-precision floating point square root.
> + Copyright (C) 2015 Free Software Foundation, Inc.
> + This file is part of the GNU C Library.
> +
> + The GNU C Library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Lesser General Public
> + License as published by the Free Software Foundation; either
> + version 2.1 of the License, or (at your option) any later version.
> +
> + The GNU C Library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Lesser General Public License for more details.
> +
> + You should have received a copy of the GNU Lesser General Public
> + License along with the GNU C Library; if not, see
> + <http://www.gnu.org/licenses/>. */
> +
> +#include <math_private.h>
> +
> +float
> +__ieee754_sqrtf (float s)
> +{
> + float res;
> + asm ("fsqrt %s0, %s1" : "=w" (res) : "w" (s));
> + return res;
> +}
> +strong_alias (__ieee754_sqrtf, __sqrtf_finite)
> diff --git a/sysdeps/aarch64/fpu/math_private.h b/sysdeps/aarch64/fpu/math_private.h
> index 52a6ad9..b3c2509 100644
> --- a/sysdeps/aarch64/fpu/math_private.h
> +++ b/sysdeps/aarch64/fpu/math_private.h
> @@ -22,6 +22,22 @@
> #include <fenv.h>
> #include <fpu_control.h>
>
> +extern __always_inline double
> +__ieee754_sqrt (double d)
> +{
> + double res;
> + asm __volatile__ ("fsqrt %d0, %d1" : "=w" (res) : "w" (d));
> + return res;
> +}
> +
> +extern __always_inline float
> +__ieee754_sqrtf (float s)
> +{
> + float res;
> + asm __volatile__ ("fsqrt %s0, %s1" : "=w" (res) : "w" (s));
> + return res;
> +}
> +
> static __always_inline void
> libc_feholdexcept_aarch64 (fenv_t *envp)
> {
>