This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][aarch64] fix inline asm clobber list in tls-macros.h
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 13 May 2015 15:46:36 +0100
- Subject: Re: [PATCH][aarch64] fix inline asm clobber list in tls-macros.h
- Authentication-results: sourceware.org; auth=none
- References: <54F82BFF dot 40209 at arm dot com>
On 5 March 2015 at 10:12, Szabolcs Nagy <szabolcs.nagy@arm.com> wrote:
> AArch64 TLS_GD macro calls __tlsget_addr from inline asm, because
> the exact TLS instruction sequence matters, but cc was not on the
> clobber list so elf/tst-tlsmod2.so was miscompiled and thus
> elf/tst-tls4 and elf/tst-tls-dlinfo tests failed.
>
> It seems tls-macros.h is only used in tests.
> Is this patch ok?
>
> Changelog:
>
> 2015-03-05 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * sysdeps/aarch64/tls-macros.h (TLS_GD): Add "cc" to the clobber list.
OK and committed for you.
/Marcus