This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/4] Consolidate gettimeofday across aarch64/s390/tile
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Torvald Riegel <triegel at redhat dot com>, Nathan Lynch <Nathan_Lynch at mentor dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 16 Apr 2015 09:24:41 -0300
- Subject: Re: [PATCH 2/4] Consolidate gettimeofday across aarch64/s390/tile
- Authentication-results: sourceware.org; auth=none
- References: <552EC85F dot 6080506 at linaro dot org> <552ED19E dot 1020401 at mentor dot com> <1429185607 dot 2909 dot 34 dot camel at triegel dot csb>
On 16-04-2015 09:00, Torvald Riegel wrote:
> On Wed, 2015-04-15 at 16:01 -0500, Nathan Lynch wrote:
>> On 04/15/2015 03:21 PM, Adhemerval Zanella wrote:
>>> diff --git a/sysdeps/unix/sysv/linux/gettimeofday.c b/sysdeps/unix/sysv/linux/gettimeofday.c
>>> new file mode 100644
>>> index 0000000..5eaafc0
>>> --- /dev/null
>>> +++ b/sysdeps/unix/sysv/linux/gettimeofday.c
>>> @@ -0,0 +1,35 @@
>>
>> [...]
>>
>>> +#include <errno.h>
>>> +#include <sys/time.h>
>>> +#if HAVE_GETTIMEOFDAY_VSYSCAL
>>
>> Name it HAVE_GETTIMEOFDAY_VSYSCALL instead?
>
> Why didn't this fail a build due to an undef warning?
>
Because I used HAVE_GETTIMEOFDAY_VSYSCAL 'consistently' over the patch.