This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] add benchmark for strcoll

From: Leonhard Holz <leonhard dot holz at web dot de>
To: Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: libc-alpha at sourceware dot org
Date: Thu, 26 Mar 2015 14:31:29 +0100
Subject: Re: [PATCH v2] add benchmark for strcoll
Authentication-results: sourceware.org; auth=none
References: <54FF35DF dot 6040709 at web dot de> <20150325104515 dot GE5023 at spoyarek dot pnq dot redhat dot com>

+static int
+bench_file_list (json_ctx_t *json_ctx, const char *dirname, const char *locale)


If you just create a file with this information once, you can collapse
this special case into the other cases and get rid of this function.


This implies that the file list outdates over time. Is this ok?

diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
index 4156f9e..2a48a34 100644
--- a/localedata/gen-locale.sh
+++ b/localedata/gen-locale.sh
@@ -30,7 +30,8 @@ generate_locale ()
     charmap=$1
     input=$2
     out=$3
-  if ${localedef_before_env} ${run_program_env} I18NPATH=. \
+  if ${localedef_before_env} ${run_program_env} \
+     I18NPATH=${common_objpfx}../localedata \


Shouldn't this be I18NPATH=${common_objpfx}localedata?

I18NPATH has to point to glibc/localedata and common_objpfx points to the builddirectory. So I18NPATH=${common_objpfx}localedata should not work.

Follow-Ups:
- Re: [PATCH v2] add benchmark for strcoll
  - From: Andreas Schwab
- Re: [PATCH v2] add benchmark for strcoll
  - From: Siddhesh Poyarekar

References:
- [PATCH v2] add benchmark for strcoll
  - From: Leonhard Holz
- Re: [PATCH v2] add benchmark for strcoll
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]