This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] sha2: new header <sha2.h>

From: Mike Frysinger <vapier at gentoo dot org>
To: Shawn Landden <shawn at churchofgit dot com>
Cc: libc-alpha at sourceware dot org
Date: Thu, 26 Mar 2015 02:24:56 -0400
Subject: Re: [PATCH] sha2: new header <sha2.h>
Authentication-results: sourceware.org; auth=none
References: <CAJusiZVeSiuBJ1NuWw9KU2fboKcz6-9s6YhiTHVga5GyW-bbFw at mail dot gmail dot com> <1427350202-281697-1-git-send-email-shawn at churchofgit dot com>

On 25 Mar 2015 23:10, Shawn Landden wrote:
> Export the SHA2 family of functions.

you should write a proper ChangeLog entry

> --- /dev/null
> +++ b/include/sha2.h

this file is missing a proper header block (licensing/copyright/etc...)

> +/* 256 bits is 32 bytes
> + * for sha2-224 truncate from end after calling sha256_final()
> + */

GNU style says use full sentences, two spaces at th eend, and cuddle the 
trailing */ marker

> +typedef struct {
> +       char __internal_state[352];

only two spaces indent
-mike

Attachment: signature.asc
Description: Digital signature

References:
- RFC: exporting sha256 sha512
  - From: Shawn Landden
- [PATCH] sha2: new header <sha2.h>
  - From: Shawn Landden

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]