This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h

From: Chris Metcalf <cmetcalf at ezchip dot com>
To: "Pinski, Andrew" <Andrew dot Pinski at caviumnetworks dot com>
Cc: "Zhang Jian(Bamvor)" <bamvor dot zhangjian at huawei dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, "apinski at cavium dot com" <apinski at cavium dot com>, "yangyingliang at huawei dot com" <yangyingliang at huawei dot com>, "bintian dot wang at huawei dot com" <bintian dot wang at huawei dot com>, "dingtianhong at huawei dot com" <dingtianhong at huawei dot com>
Date: Thu, 19 Mar 2015 12:59:38 -0400
Subject: Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
Authentication-results: sourceware.org; auth=none
Authentication-results: huawei.com; dkim=none (message not signed) header.d=none;
References: <1426674611-26427-1-git-send-email-bamvor dot zhangjian at huawei dot com> <1426674611-26427-3-git-send-email-bamvor dot zhangjian at huawei dot com>,<550AFBE6 dot 1000402 at ezchip dot com> <405BEB99-764E-474B-A3E0-7225FDE6596C at caviumnetworks dot com>

On 03/19/2015 12:49 PM, Pinski, Andrew wrote:

On Mar 19, 2015, at 9:40 AM, Chris Metcalf<cmetcalf@ezchip.com>  wrote:
>

>>On 03/18/2015 06:30 AM, Zhang Jian(Bamvor) wrote:
>>From: Yang Yingliang<yangyingliang@huawei.com>
>>
>>Use __fsword_t to make size of struct statfs equal in userspace and kernel.
>>
>>Signed-off-by: Yang Yingliang<yangyingliang@huawei.com>
>>---
>>  sysdeps/unix/sysv/linux/generic/bits/statfs.h | 24 ++++++++++++------------
>>  1 file changed, 12 insertions(+), 12 deletions(-)

>
>I don't object to this patch as a cleanup (to match the types used in the base Linux statfs.h), but can you tell me why this makes a difference to you?  On what asm-generic platform does __SWORD_TYPE != __fsword_t ?  My earlier analysis a few minutes ago suggested that was true only for alpha and x32, neither of which use the linux/generic code in glibc.

Aarch64:ILP32 will use linux/generic and will have SWORD_TYPE != __fsword_t just like x32. Basically this patch set goes on top of my already submitted patch set.

OK, thanks. But presumably this won't work right, because if you don'tset __USE_FILE_OFFSET64, and __WORDSIZE == 32, you'll end up injectingpadding fields that don't belong, via the __field64 macro?


This is basically the issue I just raised in the parallel thread with HJ.

--
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

Follow-Ups:
- Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
  - From: Bamvor Jian Zhang

References:
- [RFC PATCH 0/3] bugfix for aarch64 ILP32
  - From: Zhang Jian(Bamvor)
- [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
  - From: Zhang Jian(Bamvor)
- Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
  - From: Chris Metcalf
- Re: [RFC PATCH 2/3] ARM64: ILP32: use __fsword_t in generic/bits/statfs.h
  - From: Pinski, Andrew

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]