This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add envz_remove to the libc manual


On 03/18/2015 09:29 AM, Siddhesh Poyarekar wrote:
> +@comment envz.h +@comment GNU +@deftypefun {void} envz_remove
> (char **@var{envz}, size_t *@var{envz_len}, const char
> *@var{name}) +@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{}} +The
> @code{envz_remove} function removes an entry named @var{name} from 
> +@var{envz}, updating @code{*@var{envz}} and
> @code{*@var{envz_len}}. +@end deftypefun

The safety annotations are incorrect, see envz_add and argz_delete:

@safety{@prelim{}@mtsafe{}@asunsafe{@ascuheap{}}@acunsafe{@acsmem{}}}
@c Calls envz_remove, which calls enz_entry and argz_delete, and then
@c argz_add or equivalent code that reallocs and appends name=value.

@safety{@prelim{}@mtsafe{}@asunsafe{@ascuheap{}}@acunsafe{@acsmem{}}}
@c Calls free if no argument is left.


-- 
Florian Weimer / Red Hat Product Security


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]