This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add benchmark for strcoll
- From: Florian Weimer <fweimer at redhat dot com>
- To: Leonhard Holz <leonhard dot holz at web dot de>, libc-alpha at sourceware dot org
- Date: Tue, 10 Mar 2015 00:53:48 +0100
- Subject: Re: [PATCH] add benchmark for strcoll
- Authentication-results: sourceware.org; auth=none
- References: <54FD65DB dot 8050008 at web dot de> <20150309173715 dot GB12857 at vapier>
On 03/09/2015 06:37 PM, Mike Frysinger wrote:
> On 09 Mar 2015 10:20, Leonhard Holz wrote:
>> --- a/benchtests/bench-strcoll.c +++
>> b/benchtests/bench-strcoll.c
>>
>> +const char *locales[] = {
>
> static.
And probably even:
static const char *const locales[] = {
Order of const matters here. If I recall correctly, GCC will not warn
about duplicate const and create a non-constant silently if you get it
wrong.
--
Florian Weimer / Red Hat Product Security