This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] remove nested functions from regcomp.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Will Newton <will dot newton at linaro dot org>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 6 Mar 2015 16:35:45 -0800 (PST)
- Subject: Re: [PATCH] remove nested functions from regcomp.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdyadYuhF4zzTve8Qn4YtD0shRGq3+Tz0yXSg1cQQDB+qw at mail dot gmail dot com> <CANu=Dmg33DOcA8bWhhWoYPeo9dAG8EYUayv_e+qLHub8LP+UcA at mail dot gmail dot com> <542AC1BE dot 1080009 at redhat dot com> <CAGQ9bdz=EUw8oMJ=nVtkU_gJ7hsN=5ujmR8f5inWAY7N38a71A at mail dot gmail dot com> <CAGQ9bdzNsd-fK2jPaC1khy9nQR3zx9jO-DHRi2i5RmwyYzq2pg at mail dot gmail dot com>
>From a quick diff -ub the variance from the gnulib version does not look
all that high. I think you could undertake the harmonization changes and
get through them in just a few rounds. Do it in small stages. Start with
the purely cosmetic stuff like the comment formatting and int/bool that
will make the diff drastically smaller. The changes beyond that might need
some explanation from the gnulib folks. But I don't think any of it will
be hard.