This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] time: in strptime(), make %z accept Z as a time zone

From: Mike Frysinger <vapier at gentoo dot org>
To: Vincent Bernat <Vincent dot Bernat at exoscale dot ch>
Cc: libc-alpha at sourceware dot org, Vincent Bernat <vincent at bernat dot im>
Date: Fri, 6 Mar 2015 05:11:21 -0500
Subject: Re: [PATCH] time: in strptime(), make %z accept Z as a time zone
Authentication-results: sourceware.org; auth=none
References: <1422370092-22288-1-git-send-email-Vincent dot Bernat at exoscale dot ch> <1422371140-27932-1-git-send-email-Vincent dot Bernat at exoscale dot ch>

On 27 Jan 2015 16:05, Vincent Bernat wrote:
> In ISO 8601, the timezone can be 'Z' instead of using
> digits. 2014-08-17T12:33:12+0000 is often expressed as
> 2014-08-17T12:33:12Z.

code wise, this looks good to me.  style problems though ...

> --- a/time/strptime_l.c
> +++ b/time/strptime_l.c
>
> -	     also specified.  */
> +	     also specified. 'Z' is equivalent to +0000. */

GNU style puts two spaces after the period

>  	  {
>  	    val = 0;
>  	    while (ISSPACE (*rp))
>  	      ++rp;
> +            if (*rp == 'Z')
> +              {
> +                rp++;
> +                break;
> +              }

indentation is incorrect -- you need to start with a tab

minor nit: this code would do ++rp instead of rp++
-mike

Attachment: signature.asc
Description: Digital signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]