This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] manual/memory.texi: Remove locale from muntrace's markings
- From: Florian Weimer <fweimer at redhat dot com>
- To: Ma Shimiao <mashimiao dot fnst at cn dot fujitsu dot com>, libc-alpha at sourceware dot org
- Date: Tue, 03 Mar 2015 11:20:56 +0100
- Subject: Re: [PATCH] manual/memory.texi: Remove locale from muntrace's markings
- Authentication-results: sourceware.org; auth=none
- References: <1425367714-17334-1-git-send-email-mashimiao dot fnst at cn dot fujitsu dot com>
On 03/03/2015 08:28 AM, Ma Shimiao wrote:
> diff --git a/manual/memory.texi b/manual/memory.texi
> index 0729e70..a77c2dc 100644
> --- a/manual/memory.texi
> +++ b/manual/memory.texi
> @@ -1700,9 +1700,13 @@ systems. The prototype can be found in @file{mcheck.h}.
> @comment mcheck.h
> @comment GNU
> @deftypefun void muntrace (void)
> -@safety{@prelim{}@mtunsafe{@mtasurace{:mtrace} @mtasuconst{:malloc_hooks} @mtslocale{}}@asunsafe{@asucorrupt{} @ascuheap{}}@acunsafe{@acucorrupt{} @acsmem{} @aculock{} @acsfd{}}}
> +@safety{@prelim{}@mtunsafe{@mtasurace{:mtrace} @mtasuconst{:malloc_hooks}}@asunsafe{@asucorrupt{} @ascuheap{}}@acunsafe{@acucorrupt{} @acsmem{} @aculock{} @acsfd{}}}
> +@c As we know, only if we passes custom string format or format which
> +@c contains single quota to fprintf(), locale problem will occur.
> +@c Though calls function fprintf(), muntrace() will not execute the
> +@c area which causes locale problem.
The locale dependency is also exposed by floating point formatting (%f
for example) because the decimal separator is not always a point. So I
think your new comment is misleading.
--
Florian Weimer / Red Hat Product Security