This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Mon, 02 Mar 2015 17:59:08 -0800
Subject: Re: [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T
Authentication-results: sourceware.org; auth=none
References: <cover dot 1425246936 dot git dot fweimer at redhat dot com> <c3bb2064d9b6b4cfe0102b2b4af595da01153cbe dot 1425246936 dot git dot fweimer at redhat dot com>

Florian Weimer wrote:

  # define INT_T		int
+typedef const char *THOUSANDS_SEP_T;

A nit: if the name's not a macro, I'd keep it lower-case. Upper-case is forshouting "WATCH OUT! I LOOK LIKE A NORMAL NAME, BUT I ACTUALLY AM A MACRO!"

Follow-Ups:
- Re: [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T
  - From: Florian Weimer

References:
- [PATCH 0/6] Some vfprintf refactoring
  - From: Florian Weimer
- [PATCH 1/6] vfprintf: Introduce THOUSANDS_SEP_T
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]