This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: search locale archive again after alias expansion
- From: Andreas Schwab <schwab at suse dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>, libc-alpha at sourceware dot org
- Date: Mon, 02 Mar 2015 09:21:19 +0100
- Subject: Re: search locale archive again after alias expansion
- Authentication-results: sourceware.org; auth=none
- References: <orr4dao5h6 dot fsf at livre dot home> <20130918220004 dot B23492C09F at topped-with-meat dot com> <ory56t31yv dot fsf at livre dot home> <or8uigyac8 dot fsf at free dot home> <oregr8db48 dot fsf at livre dot home> <54E796D1 dot 40502 at redhat dot com> <oregpd19rz dot fsf at livre dot home> <mvmsidtxb78 dot fsf at hawking dot suse dot de> <oroaogzhbw dot fsf at livre dot home>
Alexandre Oliva <aoliva@redhat.com> writes:
> On Feb 26, 2015, Andreas Schwab <schwab@suse.de> wrote:
>
>> Alexandre Oliva <aoliva@redhat.com> writes:
>>> - loc_name = strdupa (loc_name);
>>> + char *loc_name = strdupa (cloc_name);
>
>> If you rename this to loc_name_copy, instead of the other way round, you
>> get nicer variable names, and a smaller delta as a bonus.
>
> Yeah, but that wouldn't have made it crystal clear that no uses of the
> original loc_name remained in the affected range ;-)
That wouldn't work either way.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."