This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][V2][BZ #17833][PING] _dl_close_worker() does not release inconsistent objects.

From: Mike Frysinger <vapier at gentoo dot org>
To: Pavel Kopyl <p dot kopyl at samsung dot com>
Cc: Carlos O'Donell <carlos at redhat dot com>, libc-alpha at sourceware dot org, Yury Gribov <y dot gribov at samsung dot com>, m dot ilin at samsung dot com, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>
Date: Sun, 1 Mar 2015 14:17:10 -0500
Subject: Re: [PATCH][V2][BZ #17833][PING] _dl_close_worker() does not release inconsistent objects.
Authentication-results: sourceware.org; auth=none
References: <54BD4F65 dot 2090108 at samsung dot com> <54BEF851 dot 70902 at redhat dot com> <54DBC3CB dot 5080703 at samsung dot com> <54F071DB dot 9040106 at samsung dot com>

On 27 Feb 2015 16:32, Pavel Kopyl wrote:
> --- /dev/null
> +++ b/elf/tst-unique5lib.cc
> @@ -0,0 +1,13 @@
> +

i know existing tests are bad examples, but lets try and start fixing that.  
namely, there should be a header here giving a quick overview of what it is 
exactly you're testing for, and a BZ reference.

> +extern int not_exist ();
> +
> +inline int make_unique ()
> +{
> +  static int unique;
> +  return ++unique;
> +}
> +
> +int foo ()
> +{
> +  return make_unique () + not_exist ();
> +}

i don't know if this is just copy & pasting, but prototypes that do not intend 
to take args should always be (void).
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- [PATCH][V3][BZ #17833] _dl_close_worker() does not release inconsistent objects.
  - From: Pavel Kopyl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]