This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.21 - Machine maintainers, please test your machines.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>, David Miller <davem at davemloft dot net>, Richard Henderson <rth at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>, Andreas Schwab <schwab at suse dot de>, "Joseph S. Myers" <joseph at codesourcery dot com>, Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, Thomas Schwinge <thomas at codesourcery dot com>, Marcus Shawcroft <marcus dot shawcroft at linaro dot org>, Chris Metcalf <cmetcalf at tilera dot com>, Chung-Lin Tang <chunglin_tang at mentor dot com>, Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, "Senkevich, Andrew" <andrew dot senkevich at intel dot com>
- Date: Fri, 23 Jan 2015 18:56:52 -0800
- Subject: Re: glibc 2.21 - Machine maintainers, please test your machines.
- Authentication-results: sourceware.org; auth=none
- References: <54C2BDD7 dot 7000304 at redhat dot com> <CAMe9rOqQYJ1PZLWevUWC2E9coXPiG6h_yUTF5cfFXudCA0P7vA at mail dot gmail dot com> <20150124014016 dot GA23003 at gmail dot com> <20150124021010 dot GA25492 at gmail dot com>
On Fri, Jan 23, 2015 at 06:10:10PM -0800, H.J. Lu wrote:
> On Fri, Jan 23, 2015 at 05:40:16PM -0800, H.J. Lu wrote:
> > On Fri, Jan 23, 2015 at 04:36:51PM -0800, H.J. Lu wrote:
> > > On Fri, Jan 23, 2015 at 1:32 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> > > > Dear Machine Maintainers,
> > > >
> > > > Please start testing your machines against glibc
> > > > master.
> > > >
> > > > Please update the glibc 2.21 release page with your
> > > > testing results:
> > > >
> > > > https://sourceware.org/glibc/wiki/Release/2.21
> > > >
> > > > If nobody objects I want to cut the release as soon
> > > > as we have results for all the machines.
> > > >
> > >
> > > We need to update __init_cpu_features in
> > > sysdeps/x86_64/multiarch/init-arch.c to support the current
> > > Intel processors.
> > >
> > > Andrew, please find out the model numbers for the current
> > > Ivy Bridge, Haswell, Broadwell and Silvermont server, desktop
> > > and mobile processors.
> > >
> > >
> >
> > We only need to deal with Silvermont since Ivy Bridge, Haswell and
> > Broadwell, which have AVX, are treated as Core i7. The new Silvermont
> > model numbers are in
> >
> > http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-optimization-manual.pdf
> >
> > I am testing this patch and I will check it in shortly.
> >
>
> This is what I checked in. Andrew, please check if it works on your
> Silvermont machine.
>
>
> H.J.
> ---
> From d37d432b715cefb695c09b41676338f25a91d30f Mon Sep 17 00:00:00 2001
> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Fri, 23 Jan 2015 17:27:09 -0800
> Subject: [PATCH] Treat model numbers 0x4a/0x4d as Silvermont
>
> * sysdeps/x86_64/multiarch/init-arch.c (__init_cpu_features):
> Treat model numbers 0x4a/0x4d as Intel Silvermont architecture.
There are more Silvermont model numbers in CHAPTER 35 MODEL-SPECIFIC
REGISTERS (MSRS):
http://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-system-programming-manual-325384.pdf
I checked in the enclosed patch.
H.J.
---
>From 972af9e8ddd870cabf8aad39b28a6e352c9cc79c Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Fri, 23 Jan 2015 18:52:45 -0800
Subject: [PATCH] Also treat model numbers 0x5a/0x5d as Silvermont
---
ChangeLog | 3 ++-
sysdeps/x86_64/multiarch/init-arch.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index c199a5d..d746e18 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,7 +1,8 @@
2015-01-23 H.J. Lu <hongjiu.lu@intel.com>
* sysdeps/x86_64/multiarch/init-arch.c (__init_cpu_features):
- Treat model numbers 0x4a/0x4d as Intel Silvermont architecture.
+ Treat model numbers 0x4a/0x4d/0x5a/0x5d as Intel Silvermont
+ architecture.
2015-01-23 H.J. Lu <hongjiu.lu@intel.com>
diff --git a/sysdeps/x86_64/multiarch/init-arch.c b/sysdeps/x86_64/multiarch/init-arch.c
index ec71918..9299360 100644
--- a/sysdeps/x86_64/multiarch/init-arch.c
+++ b/sysdeps/x86_64/multiarch/init-arch.c
@@ -81,6 +81,8 @@ __init_cpu_features (void)
case 0x37:
case 0x4a:
case 0x4d:
+ case 0x5a:
+ case 0x5d:
/* Unaligned load versions are faster than SSSE3
on Silvermont. */
#if index_Fast_Unaligned_Load != index_Prefer_PMINUB_for_stringop
--
2.1.0