This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Status of -Wundef?


Roland, Siddhesh,

The -Wundef fixes are completely done right?

I expect that as of this commit:

commit 3b566046c3e8cb252f4c0ab7b6041fef5098f1a5
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Mon Dec 29 17:39:30 2014 +0530

    Add _POSIX namespace SYSCONF macros to posix-conf-vars.list
    
    This fixes the remaining -Wundef warnings.  Tested on x86_64.
    
        * posix/posix-conf-vars.list: Add _POSIX sysconf namespace.
        * sysdeps/posix/sysconf.c: Include posix-conf-vars.h.
        (__sysconf): Use CONF_IS_* macros.

That the core issues are complete. I see Chris Metcalf had
to fix an issue after this, but it was tile-specific.

Given that a warning would become an error with -Werror
it is a requirement that you have no -Wundef warnings otherwise
your build would fail.

I've marked the remaining -Wundef release blockers as fixed
on the 2.21 release page.

Great work.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]