Re: [PATCH RFC] Add support for linux memfd_create syscall

[Michael Kerrisk <mtk dot manpages at gmail dot com>]

Hi David and Carlos,

@David: what's the state of the with respect to revising your patches for glibc?

On Fri, Nov 21, 2014 at 7:12 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 10/17/2014 05:21 AM, David Herrmann wrote:
>> The memfd_create() syscall was released with linux-3.17. It's a linux-only
>> syscall and returns a shmem file-descriptor backed by anonymous memory
>> in a kernel-internal shmem mount.
>
> In general I'm trying hard to make this kind of patch easy to accept.
>
> See the WIP consensus here:
> https://sourceware.org/glibc/wiki/Consensus#WIP:_Kernel_syscalls_wrappers
>
> In order to get your patch accepted you have answer some implicit
> questions like "How do users use it?" "Why do users need it?"
>
> From a high-level perspective your patch is missing:
>
> - A test case if possible with non-root privs, or an xcheck test if root
>   is required.
>   e.g. ./sysdeps/unix/sysv/linux/tst-memfd_create.c
>
> - Documentation for the manual covering the use of the function.
>   e.g. ./manual/llio.texi, new section under low-level IO, and specify
>   that it is Linux specific. Feel free to submit your own text to the
>   linux-kernel man pages to get a new man page created.

@ Carlos: it *sounds* like you're saying that it's glibc policy that
an API must have tests and glibc manual documentation in order to get
admitted into the library. Is that really what you mean?

FWIW, I've recently been doing heavy editing of David's man pages
patches. They're now in a much better shape for release, but there's
still a number of points I want to resolve before releasing them. In
the meantime, they are sitting in a branch at
http://git.kernel.org/cgit/docs/man-pages/man-pages.git/log/?h=draft_memfd_create
and I have just sent out a mail (linux-man@vger.kernel.org, lkml)
requesting some review of the pages.

Thanks,

Michael