This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITED][PATCH] setenv(): fix memory leak when setting large, duplicate string

On Tue, Jan 06, 2015 at 05:28:48PM -0600, Eric Biggers wrote:
> On Tue, Jan 06, 2015 at 07:24:41PM +0100, OndÅej BÃlka wrote:
> > Yes I was planning to do that but decided wait bit if Eric responds.
> If you need a ChangeLog entry you can use the following.  But I would think many
> contributors would prefer that a maintainer takes care of the ChangeLog.  It is
> redundant with the git history and it's impossible for a contributor to know the
> date on which the change will be committed.
> 2015-01-06  Eric Biggers    <>
> 	[BZ #17658]
> 	* stdlib/setenv.c: fix memory leak when setting large, duplicate string

Thanks, I've committed this now.  I agree that the ChangeLog is mostly
redundant with git history (and have advocated getting rid of them in
the past) but there isn't a consensus on this in the glibc project.
That said, the contribution checklist currently requires contributors
to submit a ChangeLog along with their patch.  If you feel strongly
about it, please feel free to discuss this and drive the change in the
contribution checklist.


Attachment: pgpsQCBiqz0HO.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]