This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Use -Wno-error=trampolines


On gentoo, at least with gcc 4.9, -Wtrampolines are enabled by default:

tst-execstack-mod.c: In function âtrymeâ:
tst-execstack-mod.c:16:8: error: trampoline generated for nested function âcallbackâ [-Werror=trampolines]
   void callback (void) { ok = true; }
           ^
	   cc1: all warnings being treated as errors

But of course these testcases require the use of trampolines.

Ok?


r~

---
 ChangeLog     | 6 ++++++
 elf/Makefile  | 2 ++
 nptl/Makefile | 1 +
 3 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 1b08fb4..7939108 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2015-01-03  Richard Henderson  <rth@redhat.com>
+
+	* elf/Makefile (CFLAGS-tst-execstack-mod.c): Add -Wno-error=trapolines
+	(CFLAGS-tst-execstack-prog.c): Likewise.
+	* nptl/Makefile (CFLAGS-tst-execstack-mod.c): Likewise.
+
 2015-01-02  Joseph Myers  <joseph@codesourcery.com>
 
 	[BZ #17748]
diff --git a/elf/Makefile b/elf/Makefile
index 11d6865..09ab68d 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -861,6 +861,8 @@ $(objpfx)tst-execstack-needed: $(objpfx)tst-execstack-mod.so
 LDFLAGS-tst-execstack-needed = -Wl,-z,noexecstack
 
 LDFLAGS-tst-execstack-prog = -Wl,-z,execstack
+CFLAGS-tst-execstack-prog.c += -Wno-error=trampolines
+CFLAGS-tst-execstack-mod.c += -Wno-error=trampolines
 endif
 
 LDFLAGS-tst-array2 = $(no-as-needed)
diff --git a/nptl/Makefile b/nptl/Makefile
index 86c44b2..dbb2d86 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -619,6 +619,7 @@ tst-exec4-ARGS = $(host-test-program-cmd)
 $(objpfx)tst-execstack: $(libdl)
 $(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so
 LDFLAGS-tst-execstack = -Wl,-z,noexecstack
+CFLAGS-tst-execstack-mod.c += -Wno-error=trampolines
 
 $(objpfx)tst-fini1mod.so: $(shared-thread-library)
 
-- 
2.1.0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]