This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCHv4, MIPS] Add support for O32 FPXX and program header based ABI information

On Tue, 23 Dec 2014, Matthew Fortune wrote:

> I'm still running the glibc testsuite on a native MIPS machine to double
> check results. I'm running with glibc configured for mips2/mips3 on a
> board with no-fpu and see 31 failures for O32, 32 for N64 and a bizarre
> set of failures about "allocate_stack: Assertion `size != 0' failed."
> for N32. None of these look anything to do with this patch so I'm collecting
> reference results before my patch to make sure.

That's more than the known set for previous releases listed at 
<>, but still should be 
independent of this patch.

> Any further feedback welcome... Assuming tests do turn out with the same PASS
> rate then I'd like to commit?

OK with changes as noted below:

> +#if __mips_fpr != 0 || _MIPS_SPFPSET != 16
> +#error This test requires -mfpxx -mno-odd-spreg
> +#endif

Missing preprocessor indentation, "# error".  Likewise in other tests.

> +static int mode[6] = { 0,
> +		       PR_FP_MODE_FR,
> +		       PR_FP_MODE_FR | PR_FP_MODE_FRE,
> +		       PR_FP_MODE_FR,
> +		       0,
> +		       PR_FP_MODE_FR | PR_FP_MODE_FRE };

Should have braces on separate lines, along the lines of:

static int mode[6] =

Likewise in other tests.

> +      if ((float)i != f || (double)i != d)

Missing spaces in casts, "(float) i", "(double) i".

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]