This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6
- From: Steve Ellcey <sellcey at imgtec dot com>
- To: Joseph Myers <joseph at codesourcery dot com>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Mon, 22 Dec 2014 09:50:04 -0800
- Subject: RE: [Patch, MIPS] Modify memset.S for mips32r6/mips64r6
- Authentication-results: sourceware.org; auth=none
- References: <2923c970-026c-4e00-be7a-0650e82421b5 at BAMAIL02 dot ba dot imgtec dot org> <6D39441BF12EF246A7ABCE6654B0235320F8CECA at LEMAIL01 dot le dot imgtec dot org> <alpine dot DEB dot 2 dot 10 dot 1412200020590 dot 29462 at digraph dot polyomino dot org dot uk>
- Reply-to: <sellcey at imgtec dot com>
On Sat, 2014-12-20 at 00:23 +0000, Joseph Myers wrote:
> Please put this in a central place (a single header that defines
> __mips_isa_rev to 0 if not already defined, for example) rather than
> duplicating "defined" tests in different places ("defined" tests are
> typo-prone and so discouraged in glibc).
Would sysdeps/unix/mips/sysdep.h be an appropriate place to define
__mips_isa_rev? That header is already used by memcpy and memset.
I thought about using asm.h but that header is visible to users and
defining it there would be a visible change that could affect user
programs. sysdep.h is internal to glibc and so does not have that
problem.
If we add it here there would be no changes needed to memcpy.S or
memset.S, though Ondrej had some useful performance comments I would
like to look at later (once we have the basic functionality checked in).
Steve Ellcey
sellcey@imgtec.com
2014-12-22 Steve Ellcey <sellcey@imgtec.com>
* sysdeps/unix/mips/sysdep.h (__mips_isa_rev): Set
to zero if not already defined.
diff --git a/sysdeps/unix/mips/sysdep.h b/sysdeps/unix/mips/sysdep.h
index d59fac0..dc70c0f 100644
--- a/sysdeps/unix/mips/sysdep.h
+++ b/sysdeps/unix/mips/sysdep.h
@@ -78,4 +78,8 @@
# define L(label) .L ## label
#endif
+#ifndef __mips_isa_rev
+# define __mips_isa_rev 0
+#endif
+
#endif