This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/4 v1.1] Use conf.list to generate spec array
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 17 Dec 2014 16:48:31 -0800 (PST)
- Subject: Re: [PATCH 4/4 v1.1] Use conf.list to generate spec array
- Authentication-results: sourceware.org; auth=none
- References: <1411122007-1461-1-git-send-email-siddhesh at redhat dot com> <1411122007-1461-5-git-send-email-siddhesh at redhat dot com> <20141001091717 dot GL2217 at spoyarek dot pnq dot redhat dot com>
> +SPEC:XBS5:_SC_XBS5 {
As I mentioned in 1/4, just use whitespace as separator.
It simplifies the awk code.
> + print "static const int nspecs = sizeof (specs) / sizeof (specs[0]);"
I know you are just reproducing what the current source has.
But this should be size_t and the loop referring to it changed too.
Otherwise OK.
Thanks,
Roland