This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: sparc: fix for missing include file

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: David Miller <davem at davemloft dot net>, neleai at seznam dot cz
Cc: wbx at openadk dot org, libc-alpha at sourceware dot org
Date: Sat, 13 Dec 2014 11:08:47 -0800
Subject: Re: sparc: fix for missing include file
Authentication-results: sourceware.org; auth=none
References: <20140913113918 dot GA22732 at waldemar-brodkorb dot de> <20141211135716 dot GA17022 at domone> <20141211 dot 150535 dot 106178897111220975 dot davem at davemloft dot net> <20141213 dot 130022 dot 1182209281374969366 dot davem at davemloft dot net>

David Miller wrote:

strncat.c: In function âstrncatâ:
strncat.c:76:6: error: âcâ may be used uninitialized in this function [-Werror=uninitialized]

This is the generic C strncat.c in string/strncat.c, and actually the
compiler is right here in that when 'n' is zero 'c' will in fact be
tested without being initialized to anything.

That's amusing, since the code works regardless of whether 'c' is initializedproperly, assuming that using an uninitialized value doesn't trap or havesimilarly bad behavior. So this looks like another candidate for adding pragmasto suppress the diagnostic. In Gnulib we'd say 'char c IF_LINT (= 0);'.

Follow-Ups:
- Re: sparc: fix for missing include file
  - From: David Miller

References:
- Re: sparc: fix for missing include file
  - From: OndÅej BÃlka
- Re: sparc: fix for missing include file
  - From: David Miller
- Re: sparc: fix for missing include file
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]