This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Fix MIPS waitid build [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rich Felker <dalias at libc dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Wed, 10 Dec 2014 21:28:50 +0000
- Subject: Re: Fix MIPS waitid build [committed]
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1412101850280 dot 32166 at digraph dot polyomino dot org dot uk> <20141210193216 dot GS4574 at brightrain dot aerifal dot cx>
On Wed, 10 Dec 2014, Rich Felker wrote:
> Wouldn't it be preferable just to fix whatever the underlying cause
> is? It sounds like some ugly and fragile hack is being used to
> position the syscall arguments on the stack and I wouldn't be
> surprised if it's only working by chance. I've seen other bad code
A single asm adjusts the stack, puts arguments there, does the syscall and
restores the stack. The frame pointer is needed to avoid the stack
pointer adjustment breaking unwind info.
--
Joseph S. Myers
joseph@codesourcery.com