This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 6/N v2] [x86_64] Vectorized math functions
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Wed, 3 Dec 2014 18:05:47 +0000
- Subject: Re: [PATCH 6/N v2] [x86_64] Vectorized math functions
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3sC3ft+LGWMOX+9hk_ig_jFNdefHxdoW4vkJ+OQc4L91w at mail dot gmail dot com>
On Tue, 2 Dec 2014, Andrew Senkevich wrote:
> +ifeq ($(build-mathvec),yes)
> +# We need to install libm.so as linker script
> +# for more comfortable use of vector math library.
> +install-lib-ldscripts := libm.so
> +libmvec-so-ver = libmvec.so$(libmvec.so-version)
> +install_subdir: $(inst_libdir)/libm.so
> +$(inst_libdir)/libm.so: $(common-objpfx)format.lds $(libm) \
> + $(common-objpfx)mathvec/$(libmvec-so-ver) \
> + $(+force)
> + (echo '/* GNU ld script'; echo '*/';\
> + cat $<; \
> + echo 'GROUP ( $(slibdir)/libm.so$(libm.so-version) ' \
> + 'AS_NEEDED ( $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \
Watch indentation. Commands inside () should be indented one space after
the initial TAB so they all line up; the 'AS_NEEDED...' argument to echo
should be indented to line up with the 'GROUP...' argument.
I think patches 5 and 6 in the series should be combined (that is,
building and installing the library should be in the same patch).
--
Joseph S. Myers
joseph@codesourcery.com