This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix dynamic linker issue with bind-now
- From: Will Newton <will dot newton at linaro dot org>
- To: Petar Jovanovic <petar dot jovanovic at rt-rk dot com>
- Cc: Mike Frysinger <vapier at gentoo dot org>, libc-alpha <libc-alpha at sourceware dot org>, petar dot jovanovic at imgtec dot com, David Miller <davem at davemloft dot net>
- Date: Wed, 3 Dec 2014 09:36:30 +0000
- Subject: Re: [PATCH] Fix dynamic linker issue with bind-now
- Authentication-results: sourceware.org; auth=none
- References: <1408493406-86741-1-git-send-email-petar dot jovanovic at rt-rk dot com> <1408493406-86741-2-git-send-email-petar dot jovanovic at rt-rk dot com> <000a01cfe8dd$488fbdf0$d9af39d0$ at rt-rk dot com> <20141021213320 dot GA25185 at vapier> <000301d00e87$8284f5f0$878ee1d0$ at rt-rk dot com>
Hi Petar,
I think this patch could really use comments explaining what is
happening for future readers of the code (both in dynamic-link.h and
the test). I also think tst-dynamic-link is quite a generic name and
it might be better to rename it to something more specific e.g.
tst-split-dynreloc or something like that.
It would also be good to mention how the patch was tested e.g. which platforms.
On 2 December 2014 at 23:27, Petar Jovanovic <petar.jovanovic@rt-rk.com> wrote:
> Ping.
>
> -----Original Message-----
> From: Petar Jovanovic [mailto:petar.jovanovic@rt-rk.com]
> Sent: Friday, November 14, 2014 3:07 AM
> To: 'Mike Frysinger'
> Cc: 'libc-alpha@sourceware.org'; 'petar.jovanovic@imgtec.com'; 'davem@davemloft.net'
> Subject: RE: [PATCH] Fix dynamic linker issue with bind-now
>
> Any additional comments here?
>
> Regards,
> Petar
>
> -----Original Message-----
> From: Petar Jovanovic [mailto:petar.jovanovic@rt-rk.com]
> Sent: Friday, October 31, 2014 3:47 AM
> To: 'Mike Frysinger'
> Cc: 'libc-alpha@sourceware.org'; 'petar.jovanovic@imgtec.com'; 'davem@davemloft.net'
> Subject: RE: [PATCH] Fix dynamic linker issue with bind-now
>
> Hi Mike,
>
> This was not clear to me, otherwise I would add the test case in a patch.
> Thanks for the explanation. Here it is again.
>
> Let me know if you want some modification.
>
> Regards,
> Petar
>
> -----Original Message-----
> From: Mike Frysinger [mailto:vapier@gentoo.org]
> Sent: Tuesday, October 21, 2014 2:33 PM
> To: Petar Jovanovic
> Cc: libc-alpha@sourceware.org; petar.jovanovic@imgtec.com; davem@davemloft.net
> Subject: Re: [PATCH] Fix dynamic linker issue with bind-now
>
> On 16 Oct 2014 03:05, Petar Jovanovic wrote:
>> Do you any additional data/feedback to proceed with this issue?
>
> when Roland asked for a testcase, the implication was to include it in glibc itself so it'd be compiled & run as part of `make check`. that way we won't accidentally regress in the future.
> -mike
>
--
Will Newton
Toolchain Working Group, Linaro