This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Reset cached offset when reading to end of stream (BZ #17653)
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org, carlos at redhat dot com
- Date: Thu, 27 Nov 2014 16:44:12 +0100
- Subject: Re: [PATCH] Reset cached offset when reading to end of stream (BZ #17653)
- Authentication-results: sourceware.org; auth=none
- References: <20141127122839 dot GA31809 at spoyarek dot pnq dot redhat dot com> <87sih4vkpg dot fsf at igel dot home> <20141127150731 dot GB24022 at spoyarek dot pnq dot redhat dot com>
Siddhesh Poyarekar <siddhesh@redhat.com> writes:
> diff --git a/libio/wfileops.c b/libio/wfileops.c
> index 71281c1..267b093 100644
> --- a/libio/wfileops.c
> +++ b/libio/wfileops.c
> @@ -268,6 +268,7 @@ _IO_wfile_underflow (fp)
> /* There are some bytes in the external buffer but they don't
> convert to anything. */
> __set_errno (EILSEQ);
> + fp->_offset = _IO_pos_BAD;
> return WEOF;
For the case of naccbuf != 0 this isn't really EOF, but an error. No
other error case is resetting _offset. Also, what about
_IO_wfile_underflow_mmap?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."