This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Avoid warnings for unused results in nscd/connections.c
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 27 Nov 2014 14:36:24 +0530
- Subject: Re: Avoid warnings for unused results in nscd/connections.c
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411261900020 dot 854 at digraph dot polyomino dot org dot uk> <m56n27$lv4$1 at ger dot gmane dot org>
On 27 November 2014 at 13:53, Stefan Liebler <stli@linux.vnet.ibm.com> wrote:
> Building glibc fails at least on s390/power with:
> connections.c: In function ârestartâ:
> connections.c:1467:4: error: implicit declaration of function âignore_valueâ
> [-Werror=implicit-function-declaration]
> ignore_value (setuid (server_uid));
> ^
> cc1: some warnings being treated as errors
>
> Including libc-internal.h fixes the build failure.
>
> Bye
> Stefan
>
> ---
> 2014-11-27 Stefan Liebler <stli@linux.vnet.ibm.com>
>
> * nscd/connections.c: Include libc-internal.h
> because of macro usage ignore_value.
libc-internal.h got included indirectly on x86_64 (via
sysdeps/x86_64/tls.h), which is why it worked there and not on other
architectures. This fix is correct, please commit it.
Siddhesh
--
http://siddhesh.in