Re: [PATCH RFC] Add support for linux memfd_create syscall

["Carlos O'Donell" <carlos at redhat dot com>]

On 10/17/2014 05:21 AM, David Herrmann wrote:
> The memfd_create() syscall was released with linux-3.17. It's a linux-only
> syscall and returns a shmem file-descriptor backed by anonymous memory
> in a kernel-internal shmem mount.

In general I'm trying hard to make this kind of patch easy to accept.

See the WIP consensus here:
https://sourceware.org/glibc/wiki/Consensus#WIP:_Kernel_syscalls_wrappers

In order to get your patch accepted you have answer some implicit
questions like "How do users use it?" "Why do users need it?"

>From a high-level perspective your patch is missing:

- A test case if possible with non-root privs, or an xcheck test if root
  is required.
  e.g. ./sysdeps/unix/sysv/linux/tst-memfd_create.c

- Documentation for the manual covering the use of the function.
  e.g. ./manual/llio.texi, new section under low-level IO, and specify
  that it is Linux specific. Feel free to submit your own text to the
  linux-kernel man pages to get a new man page created.

Lastly you'll want to review:
https://sourceware.org/glibc/wiki/Contribution%20checklist

The present patch is mechanical in nature and doesn't require copyright
assignment, but adding the test case, and manual entry brings you into
legally significant territory. Do you have a copyright assignment with
the FSF for glibc?

Cheers,
Carlos.