This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2] Add x86 32 bit vDSO time function support
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org
- Date: Fri, 14 Nov 2014 17:19:30 -0200
- Subject: Re: [PATCH v2] Add x86 32 bit vDSO time function support
- Authentication-results: sourceware.org; auth=none
- References: <5436D48C dot 2090509 at linux dot vnet dot ibm dot com> <5436F50C dot 9070002 at codesourcery dot com> <5457E5D5 dot 6000103 at linux dot vnet dot ibm dot com> <54581516 dot 9010908 at codesourcery dot com> <545A1D38 dot 8030700 at linux dot vnet dot ibm dot com> <545A4EC3 dot 80003 at codesourcery dot com>
On 05-11-2014 14:22, Nathan Lynch wrote:
> On 11/05/2014 06:51 AM, Adhemerval Zanella wrote:
>> On 03-11-2014 21:51, Nathan Lynch wrote:
>>>> i386 does not define HAVE_CLOCK_GETTIME_VSYSCALL and thus:
>>>> 26: # define INTERNAL_VSYSCALL INTERNAL_SYSCALL
>>>> and then if INTERNAL_GETTIME is not defined, it will as:
>>>> 37 #ifndef INTERNAL_GETTIME
>>>> 38 # define INTERNAL_GETTIME(id, tp) \
>>>> 39 INTERNAL_VSYSCALL (clock_gettime, err, 2, id, tp)
>>>> 40 #endif
>>>> And without proper set the PTR_DEMANGLE is not called either.
>>> I think my point might be better expressed as: why is INTERNAL_GETTIME
>>> defined in linux/clock_gettime.c at all? It is not used in the
>>> clock_gettime implementation.
>>> The only use in glibc of a macro by that name is in
>>> linux/timespec_get.c, and the arch can override it in its own
>>> timespec_get.c (as x86_64 currently does).
>> I see your point and I removed its definition now for x86. Below it's the revised
> I have no further concerns, thanks.
Ping, is this patch ok to commit?