This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] Add arch-specific configuration for C11 atomics support.

From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
To: libc-alpha at sourceware dot org
Date: Tue, 11 Nov 2014 19:20:08 -0200
Subject: Re: [PATCH 1/4] Add arch-specific configuration for C11 atomics support.
Authentication-results: sourceware.org; auth=none
References: <1414617613 dot 10085 dot 23 dot camel at triegel dot csb> <1414618740 dot 10085 dot 35 dot camel at triegel dot csb>

Hi Torvald,

Patch looks ok in general, some comments regarding Changelog entry:

On 29-10-2014 19:39, Torvald Riegel wrote:

>
> 	* sysdeps/aarch64/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Define.
> 	* sysdeps/alpha/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/arm/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/i386/i486/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.

I believe it should be sysdeps/i386/i486/bits/atomic.h.  Same for other archs
as well (powerpc for instance).

> 	* sysdeps/ia64/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/m68k/coldfire/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/m68k/m680x0/m68020/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/microblaze/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/mips/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/powerpc/powerpc32/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/powerpc/powerpc64/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/s390/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/sparc/sparc32/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/sparc/sparc32/sparcv9/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/sparc/sparc64/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/tile/tilegx/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/tile/tilepro/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/unix/sysv/linux/hppa/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/unix/sysv/linux/m68k/coldfire/bits/atomic.h
> 	(__HAVE_64B_ATOMICS, USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/unix/sysv/linux/sh/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.
> 	* sysdeps/x86_64/bits/atomic.h (__HAVE_64B_ATOMICS,
> 	USE_ATOMIC_COMPILER_BUILTINS): Likewise.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]