This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Minimum GCC version for building glibc
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: Paul Eggert <eggert at cs dot ucla dot edu>, <libc-alpha at sourceware dot org>
- Date: Wed, 5 Nov 2014 21:08:20 +0000
- Subject: Re: Minimum GCC version for building glibc
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1410311352200 dot 4263 at digraph dot polyomino dot org dot uk> <20141104165815 dot GK5402 at vapier dot wh0rd dot info> <5459239B dot 4020901 at cs dot ucla dot edu> <20141105184731 dot GP5402 at vapier dot wh0rd dot info> <alpine dot DEB dot 2 dot 10 dot 1411051851100 dot 1007 at digraph dot polyomino dot org dot uk> <20141105193740 dot GR5402 at vapier dot wh0rd dot info>
On Wed, 5 Nov 2014, Mike Frysinger wrote:
> any time you use a gcc feature you must review to see if it's supported by the
> versions we support. bumping the min gcc version doesn't preclude that. if
No (even if autoconf kept testing for ISO C90 features long after doing so
was unnecessary). You just need to be aware of what's recent and not care
about the versions in which longstanding features were introduced - and
expanding the set of features that count as longstanding reduces the load
of keeping track of what's recent (you only need to review if using a
feature that might be on the borderline, and otherwise can either use
features without thinking about compiler versions, or know that a feature
is only usable conditionally, either of which is much more efficient than
needing to check).
> > I think -Werror makes it more likely building with old versions will break
> > when they aren't actively tested. We also now have a clear use for
> > diagnostic pragmas, new in 4.6, to allow more selective disabling of
> > particular warnings together with -Werror.
>
> -Werror makes sense when building from git / maintainer mode, but not in any
> other scenario (such as unpacking release tarballs and running plain configure).
Defaulting to disabling -Werror for releases (or based on compiler
version) was previously objected to in
<https://sourceware.org/ml/libc-alpha/2012-08/msg00404.html>.
> so your argument hinges on whether the new atomic logic should require gcc 4.7.
> that should probably shake out in the relevant threads and once it has, you've
> got a compelling reason for dropping <4.7. but i still don't see any
> justification for, if we are retaining 4.6, why we should drop 4.4 & 4.5.
It's already been stated - using #pragma GCC diagnostic push/pop to help
with -Werror usage.
--
Joseph S. Myers
joseph@codesourcery.com