Re: [Patch][BZ 17506] fix tst-strcoll-overflow returning before timeout

[Siddhesh Poyarekar <siddhesh at redhat dot com>]

On Sat, Oct 25, 2014 at 01:48:39PM +0200, Leonhard Holz wrote:
> Modifies the test examination in test-skeleton.c so that a test can be
> successful if it is interrupted or it returns uninterrupted with the
> expected status. For this both EXPECTED_SIGNAL and EXPECTED_STATUS have to
> be set, as is done in tst-strcoll-overflow.c.

This is unnecessary.  The test is intended to catch crashes on any
kind of overflows that may have been caused in strcoll due to large
string inputs (CVE-2012-4412 for example).  The timeout and alarm are
there because the non-cached version would go on forever since it was
really slow.

With your performance improvements the test completes sucessfully
without a crash but it doesn't actually go through all four passes.
The ideal fix to the test case would be to have a really large string
that is not binary identical like it currently is, but that'll be
quite hard to do right now.  For now, it should be sufficient to just
get rid of the EXPECTED_SIGNAL, reduce the TIMEOUT to a smaller value
and adjust the big comment in the test to reflect the new reality.

Siddhesh

Attachment: pgpBUNnXOpron.pgp
Description: PGP signature