This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Elision, both for s390 and x86_64, should be enabled via --enable-lock-elision=yes.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>, Andi Kleen <andi at firstfloor dot org>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Mon, 29 Sep 2014 19:00:42 -0400
- Subject: Re: [PATCH] Elision, both for s390 and x86_64, should be enabled via --enable-lock-elision=yes.
- Authentication-results: sourceware.org; auth=none
- References: <5429B916 dot 4040303 at redhat dot com> <8738baqc80 dot fsf at igel dot home>
On 09/29/2014 06:43 PM, Andreas Schwab wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>
>> diff --git a/configure b/configure
>> index 89566c5..9a9cf08 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1413,7 +1413,7 @@ Optional Features:
>> initialize __stack_chk_guard canary with a random
>> number at program start
>> --enable-lock-elision=yes/no
>> - Enable lock elision for pthread mutexes by default
>> + Enable hardware lock elision by default
>> --enable-add-ons[=DIRS...]
>> configure and build add-ons in DIR1,DIR2,... search
>> for add-ons if no parameter given
>> diff --git a/configure.ac b/configure.ac
>> index 82d0896..d113772 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -169,7 +169,7 @@ fi
>>
>> AC_ARG_ENABLE([lock-elision],
>> AC_HELP_STRING([--enable-lock-elision[=yes/no]],
>
> While you are at it, please remove [=yes/no]. This is common to all
> --enable- options, and as you see above this is underquoted, so that the
> brackets are eaten by m4.
Done. Thanks for the review.
Cheers,
Carlos.