This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] nptl: Fix Race conditions in pthread cancellation, (BZ#12683)

On Fri, 19 Sep 2014, Joseph S. Myers wrote:

> For cases like this, it seems to me that you should be able to do a 
> preliminary patch that defines SYSCALL_CANCEL in a way that expands to the 
> existing code using LIBC_CANCEL_ASYNC, INLINE_SYSCALL and 
> LIBC_CANCEL_RESET.  If you can define some of the new macros like that, 
> then you can change most or all such code for all architectures to the new 
> idiom (reasonably safely without being able to test on all the 
> architectures), reducing the size of the per-architecture patches needed 
> later and of the patches with the changes that actually fix the main 
> issue.

Also, if the function in question has a "Consider moving to 
syscalls.list." comment (as in 
sysdeps/unix/sysv/linux/powerpc/powerpc64/pread.c, for example), then if 
in fact everything that C function does is equivalent to something that 
can be represented in syscalls.list, doing that move (part of bug 14138) 
would serve equally well for this purpose.  (For your patch series, of 
course only the part of bug 14138 dealing with functions with cancellation 
handling is relevant.)

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]