This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ARM: Don't define _SYS_AUXV_H in sysdep.h


On Fri, 12 Sep 2014, Will Newton wrote:

> sysdep.h was defining _SYS_AUXV_H in order to avoid an include guard check
> in hwcap.h. Unfortunately it didn't undefine it so it could leak out into
> code and caused a build failure with -Wimplicit-function-declaration
> building tst-auxv on ARM.
> 
> ChangeLog:
> 
> 2014-09-11  Will Newton  <will.newton@linaro.org>
> 
> 	* sysdeps/unix/sysv/linux/arm/bits/hwcap.h: Check for
> 	_LINUX_ARM_SYSDEP_H include guard too.

Rather than referring to a guard for an internal header in an installed 
header, I think it would be better to test for _LIBC there.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]