This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove locale-related environment variables from subprocess environments
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 10 Sep 2014 20:32:21 +0000
- Subject: Re: [PATCH] Remove locale-related environment variables from subprocess environments
- Authentication-results: sourceware.org; auth=none
- References: <540DA507 dot 2090400 at redhat dot com> <20140909211103 dot 281012C39D8 at topped-with-meat dot com> <5410269D dot 9030603 at redhat dot com> <20140910174612 dot 7B5F32C39CB at topped-with-meat dot com>
On Wed, 10 Sep 2014, Roland McGrath wrote:
> > Hmm. Is it fine to require that test-wrapper-env supports the -u option
> > of env? There is no other way to unset environment variables at this
> > point, as far as I can see.
>
> I think using -u is OK, but Joseph might have an opinion. If it's a
> problem, then for all these particular variables setting them to empty is
> probably equivalent.
Well, you need to update the documentation in install.texi of what the
arguments to test-wrapper-env look like. But I'm not aware of any wrapper
implementations that don't just go through env (whether by using
cross-test-ssh.sh, or the default empty wrapper), though in principle you
could have such an implementation (e.g. using userspace QEMU, where the
program "env" may not exist in a form it can execute ... not that I know
if userspace QEMU actually has a suitable mechanism for setting
environment variables that only apply to the emulated program and not to
QEMU itself). A NEWS entry mentioning the new requirements might still be
a good idea.
--
Joseph S. Myers
joseph@codesourcery.com